feat(lobby): added a new player component parameter to notifysessionstart command to streamline processes#892
Merged
Conversation
…tart command to streamline processes
Contributor
Author
How to use the Graphite Merge QueueAdd the label graphite/merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
AnthonyWadham
approved these changes
Apr 29, 2026
zulkhair
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Include player data in the session start notification sent to the game shard.
What changed?
NotifySessionStartCommandnow includes aPlayersfield containing the list ofPlayerComponententries associated with the lobby. ThedispatchSessionStartfunction was updated to accept alobbyIndexparameter, which is used to gather the lobby's players viagatherLobbyPlayersbefore sending the command.How to test?
Start a lobby session and verify that the game shard receives a
NotifySessionStartCommandwith a populatedPlayersfield that correctly reflects the players in the lobby at the time the session starts.Why make this change?
The game shard previously had no information about which players were part of a session when it started. By including the player list in the session start notification, the game shard can immediately act on player data without needing to query back to the lobby world.